Add tests for iterators (#22)

Unleash · Aug 18, 2021 · 48ae6cb · 48ae6cb
1 parent f21af33
commit 48ae6cb
Show file tree

Hide file tree

Showing 4 changed files with 48 additions and 5 deletions.
diff --git a/src/Client/DefaultRegistrationService.php b/src/Client/DefaultRegistrationService.php
@@ -34,9 +34,7 @@ public function register(iterable $strategyHandlers): bool
             return true;
         }
         if (!is_array($strategyHandlers)) {
-            // @codeCoverageIgnoreStart
             $strategyHandlers = iterator_to_array($strategyHandlers);
-            // @codeCoverageIgnoreEnd
         }
         $request = $this->requestFactory
             ->createRequest('POST', $this->configuration->getUrl() . 'client/register')

diff --git a/src/DefaultUnleash.php b/src/DefaultUnleash.php
@@ -47,9 +47,7 @@ public function isEnabled(string $featureName, ?Context $context = null, bool $d
 
         $strategies = $feature->getStrategies();
         if (!is_countable($strategies)) {
-            // @codeCoverageIgnoreStart
             $strategies = iterator_to_array($strategies);
-            // @codeCoverageIgnoreEnd
         }
         if (!count($strategies)) {
             $this->metricsHandler->handleMetrics($feature, true);

diff --git a/tests/Client/DefaultRegistrationServiceTest.php b/tests/Client/DefaultRegistrationServiceTest.php
@@ -2,6 +2,7 @@
 
 namespace Unleash\Client\Tests\Client;
 
+use ArrayIterator;
 use GuzzleHttp\Psr7\HttpFactory;
 use Unleash\Client\Client\DefaultRegistrationService;
 use Unleash\Client\Configuration\UnleashConfiguration;
@@ -27,10 +28,13 @@ public function testRegister()
             $configuration
         );
 
-        $this->pushResponse([], 1, 202);
+        $this->pushResponse([], 2, 202);
         self::assertTrue($instance->register([
             new DefaultStrategyHandler(),
         ]));
+        self::assertTrue($instance->register(new ArrayIterator([
+            new DefaultStrategyHandler(),
+        ])));
 
         $this->pushResponse([
             'type' => 'password',

diff --git a/tests/DefaultUnleashTest.php b/tests/DefaultUnleashTest.php
@@ -2,12 +2,17 @@
 
 namespace Unleash\Client\Tests;
 
+use ArrayIterator;
+use LimitIterator;
 use Unleash\Client\Configuration\UnleashConfiguration;
 use Unleash\Client\Configuration\UnleashContext;
 use Unleash\Client\DefaultUnleash;
+use Unleash\Client\DTO\DefaultFeature;
+use Unleash\Client\DTO\DefaultStrategy;
 use Unleash\Client\DTO\Feature;
 use Unleash\Client\DTO\Variant;
 use Unleash\Client\Metrics\MetricsHandler;
+use Unleash\Client\Repository\UnleashRepository;
 use Unleash\Client\Stickiness\MurmurHashCalculator;
 use Unleash\Client\Strategy\DefaultStrategyHandler;
 use Unleash\Client\Strategy\GradualRolloutStrategyHandler;
@@ -452,6 +457,44 @@ public function testRegister()
         self::assertCount(3, $this->requestHistory);
     }
 
+    public function testIterators()
+    {
+        $repository = new class implements UnleashRepository {
+            private $cache = [];
+
+            public function findFeature(string $featureName): ?Feature
+            {
+                if (!isset($this->cache[$featureName])) {
+                    $this->cache[$featureName] = new DefaultFeature(
+                        $featureName,
+                        true,
+                        new LimitIterator(new ArrayIterator([new DefaultStrategy('default')])),
+                    );
+                }
+
+                return $this->cache[$featureName];
+            }
+
+            public function getFeatures(): iterable
+            {
+                return [];
+            }
+        };
+
+        $instance = new DefaultUnleash(
+            new ArrayIterator([new DefaultStrategyHandler()]),
+            $repository,
+            $this->registrationService,
+            (new UnleashConfiguration('', '', ''))
+                ->setAutoRegistrationEnabled(false)
+                ->setCache($this->getCache()),
+            $this->metricsHandler,
+            new DefaultVariantHandler(new MurmurHashCalculator())
+        );
+        self::assertTrue($instance->isEnabled('someFeature'));
+        self::assertTrue($instance->isEnabled('someFeature'));
+    }
+
     private function getInstance(StrategyHandler ...$handlers): DefaultUnleash
     {
         return new DefaultUnleash(