Skip to content

Commit

Permalink
wip: revert type change from iterable to array
Browse files Browse the repository at this point in the history
  • Loading branch information
sighphyre committed Nov 8, 2023
1 parent d788737 commit 68c5881
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/Repository/DefaultUnleashRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
* @phpstan-type DependencyArray array{
* feature: string,
* enabled: bool,
* variants?: array<string>,
* variants?: iterable<string>,
* }
*/
final readonly class DefaultUnleashRepository implements UnleashRepository
Expand Down Expand Up @@ -90,7 +90,7 @@ public function findFeature(string $featureName): ?Feature
* @throws ClientExceptionInterface
* @throws JsonException
*
* @return array<Feature>
* @return iterable<Feature>
*/
public function getFeatures(): array

Check failure on line 95 in src/Repository/DefaultUnleashRepository.php

View workflow job for this annotation

GitHub Actions / Static analysis (8.2)

Method Unleash\Client\Repository\DefaultUnleashRepository::getFeatures() return type has no value type specified in iterable type array.

Check failure on line 95 in src/Repository/DefaultUnleashRepository.php

View workflow job for this annotation

GitHub Actions / Static analysis (8.2)

PHPDoc tag @return with type iterable<Unleash\Client\DTO\Feature> is not subtype of native type array.
{
Expand Down

0 comments on commit 68c5881

Please sign in to comment.