Add tests for iterators

Unleash · Aug 18, 2021 · fa402b3 · fa402b3
1 parent f21af33
commit fa402b3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/Client/DefaultRegistrationService.php b/src/Client/DefaultRegistrationService.php
@@ -34,9 +34,7 @@ public function register(iterable $strategyHandlers): bool
             return true;
         }
         if (!is_array($strategyHandlers)) {
-            // @codeCoverageIgnoreStart
             $strategyHandlers = iterator_to_array($strategyHandlers);
-            // @codeCoverageIgnoreEnd
         }
         $request = $this->requestFactory
             ->createRequest('POST', $this->configuration->getUrl() . 'client/register')

diff --git a/tests/Client/DefaultRegistrationServiceTest.php b/tests/Client/DefaultRegistrationServiceTest.php
@@ -2,6 +2,7 @@
 
 namespace Unleash\Client\Tests\Client;
 
+use ArrayIterator;
 use GuzzleHttp\Psr7\HttpFactory;
 use Unleash\Client\Client\DefaultRegistrationService;
 use Unleash\Client\Configuration\UnleashConfiguration;
@@ -27,10 +28,13 @@ public function testRegister()
             $configuration
         );
 
-        $this->pushResponse([], 1, 202);
+        $this->pushResponse([], 2, 202);
         self::assertTrue($instance->register([
             new DefaultStrategyHandler(),
         ]));
+        self::assertTrue($instance->register(new ArrayIterator([
+            new DefaultStrategyHandler(),
+        ])));
 
         $this->pushResponse([
             'type' => 'password',