Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Use both (stale and normal) caches for registration #139

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Feat: Use both (stale and normal) caches for registration #139

merged 1 commit into from
Jan 4, 2023

Conversation

RikudouSage
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed (if any).

Fixes #132

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests
  • Integration tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

sighphyre
sighphyre approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RikudouSage RikudouSage merged commit 378a309 into main Jan 4, 2023
@RikudouSage RikudouSage deleted the feat/stale-client-registration branch January 4, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighphyre sighphyre sighphyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: When Client Registration Fails on init/build, allow to proceed and use Stale Cache if it exists
2 participants
@RikudouSage @sighphyre