New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for psr/http-message:^2.0 #150
Conversation
It doesn't seem to pass tests. |
Sorry, there was a typo. Should be fixed now. I was able to run the test suite locally. |
Can you make it accept ^1.0 as well? Also remove the changes from StringStream, I feel like it adds unnecessary BC break, the only change that's needed is adding |
I've just removed my changes. |
As mentioned before, the only change that's needed is adding string return type to __toString(), otherwise it doesn't pass. If you rebase the current main branch, additional tests would be ran that should catch the error. |
Are here any updates on this? |
@RikudouSage I have just rebased and the tests are still green. I don't see how the requested change should be related to the changeset of this MR. Please let me know if you still want me to change this method signature. |
Hm, that's weird, I'll check it out today. |
Hm, it seems to work because PHP internally adds I'm talking about the method |
@RikudouSage I just added the return type as suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Release notes for
psr/http-message:^2.0
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.