Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return disabled variant when feature evaluated false #172

Merged
merged 9 commits into from Aug 16, 2023
Merged

fix: return disabled variant when feature evaluated false #172

merged 9 commits into from Aug 16, 2023

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Aug 16, 2023

Fixes #171

  1. Updated client spec to 4.2.3
  2. Now getVariant will return disabled variant when feature is evaluated to false.

kwasniew
kwasniew reviewed Aug 16, 2023
View reviewed changes
src/DefaultUnleash.php Outdated Show resolved Hide resolved
sighphyre
sighphyre approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good

@sjaanus
Copy link
Contributor Author

sjaanus commented Aug 16, 2023

Codacy review seems not relevant.

@sjaanus sjaanus merged commit e7cbbfd into main Aug 16, 2023
11 of 12 checks passed
@sjaanus sjaanus deleted the variant-when-disabled branch August 16, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwasniew kwasniew kwasniew left review comments

@sighphyre sighphyre sighphyre approved these changes

@RikudouSage RikudouSage Awaiting requested review from RikudouSage

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: when feature is evaluated false, it should return disabled variant
3 participants
@sjaanus @kwasniew @sighphyre