fix: use a fixed hash seed for variant hashing #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ariant distribution
RikudouSage
reviewed
Oct 30, 2023
RikudouSage
reviewed
Oct 30, 2023
RikudouSage
reviewed
Oct 30, 2023
…s to hashing but not not yet implemented features
RikudouSage
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces the variant distribution to use a seeded hash, rather than falling back to the default of 0.
This fixes an issue in the variant distribution when gradual rollout is at play, since that narrows down the potential buckets before variants kick in. Previously, we'd see very non random distributions of variants in those cases. This change allows for a more statistically sane distribution
This PR hasn't updated the client-spec, since this requires dependent features to get merged first in order for the specs to pass. Manually validated by removing the dependent features test case and running the rest of the tests. Because of this, this PR won't pass until that feature gets merged or we backport a version for the client spec