Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate MetricsCache from common Cache. #180

Merged

Conversation

vbartusevicius
Copy link
Contributor

@vbartusevicius vbartusevicius commented Nov 1, 2023

Description

Previously, the metrics cache relied on the shared cache. When ArrayCache or a similar short-lived shared cache is used, it effectively ignores "metricsInterval" because ArrayCache lives up until the request ends.
In high-load applications, the "metricsInterval=0" approach is ineffective because it will increase the overall page load time.

By separating the Metrics cache from the shared one, "metricsInterval" is honored. Feature cache may have any suitable implementation it needs.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@RikudouSage RikudouSage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@RikudouSage RikudouSage merged commit 050bc28 into Unleash:main Nov 13, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants