Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with transpiled release info for PHP versions #190

Closed
wants to merge 1 commit into from

Conversation

markunl
Copy link

@markunl markunl commented Dec 1, 2023

Description

Updates README.md with transpiled release info guidance for users to match SDK releases to their version of PHP.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Previewed readme changes for formatting.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@RikudouSage
Copy link
Collaborator

Is that necessary? If you run it without any version, the biggest version available is installed - if you're on PHP 7.4, the version for 7.4 will be installed. Though it might be a problem if production uses different version than dev machine.

@markunl
Copy link
Author

markunl commented Dec 1, 2023

Is that necessary? If you run it without any version, the biggest version available is installed - if you're on PHP 7.4, the version for 7.4 will be installed. Though it might be a problem if production uses different version than dev machine.

Makes sense, we can drop this. Main motivation behind the update was a user asking for help and not being clear on which version of the SDK they should be using with their PHP version. But if this is handled automatically during install then I agree no update needed.

@markunl markunl closed this Dec 1, 2023
@RikudouSage RikudouSage deleted the readme-update-with-transpired-release-info branch December 1, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants