Feat: Bootstrapping #44
Conversation
…ing without required parameters when fetching disabled
| } catch (Exception $exception) { | ||
| // empty catch, $data does not exist and will be handled below | ||
| } | ||
| $data ??= $this->getBootstrappedResponse(); |
There was a problem hiding this comment.
Nice, I have not seen that operator before!
Would it make sense to validate if it is anything more than an empty string?
What if it is an empty list of feature toggles?
There was a problem hiding this comment.
Empty string couldn't pass here, an exception would be thrown somewhere in the providers. Empty feature toggle list is a valid response, no? For example, if your unleash server goes down you want to play it safe and don't let anyone see a list of any flag guarded features.
I can add some validator that it at least is in valid format to fail early, but I think we shouldn't check for more than the data having a "features" key and it being an array.
There was a problem hiding this comment.
but I think we shouldn't check for more than the data having a "features" key and it being an array.
Agreed!
There was a problem hiding this comment.
@ivarconr I added the check in the latest commit.
closes #43
Implemented according to specifications - if the request to unleash api fails it falls back to a bootstrap provider (if present).
Also added a configuration parameter to disable fetching the api at all in which case these things are disabled:
If fetching is disabled and no bootstrap is provided, an exception is thrown.