Merge a29d6f4 into e28232f

UnleashClient/api/register.py

@@ -1,6 +1,7 @@
 import json
 from datetime import datetime, timezone
 import requests
+from requests.exceptions import MissingSchema, InvalidSchema, InvalidURL, InvalidHeader
 from UnleashClient.constants import SDK_NAME, SDK_VERSION, REQUEST_TIMEOUT, APPLICATION_HEADERS, REGISTER_URL
 from UnleashClient.utils import LOGGER, log_resp_info
 
@@ -55,6 +56,9 @@ def register_client(url: str,
         LOGGER.info("Unleash Client successfully registered!")
 
         return True
+    except (MissingSchema, InvalidSchema, InvalidHeader, InvalidURL) as exc:
+        LOGGER.exception("Unleash Client registration failed fatally due to exception: %s", exc)
+        raise exc
     except requests.RequestException as exc:
         LOGGER.exception("Unleash Client registration failed due to exception: %s", exc)
 

docs/changelog.md

@@ -1,6 +1,8 @@
 ## Next version
 
 ## Upcoming
+* (Minor) `initialize_client()` will raise exception if UnleashClient is configured with an invalid URL.
+* (Minor) Exclude test package from dist & wheel.  Thanks @ameyajoshi99!
 * (Minor) Allow users to specify log-level for when `is_enabled()` or `get_varients()` calls fail.
 
 ## v4.2.0

tests/unit_tests/test_client.py

@@ -362,3 +362,17 @@ def test_uc_server_error_recovery(unleash_client):
     responses.add(responses.GET, URL + FEATURES_URL, json=MOCK_FEATURE_RESPONSE, status=200)
     time.sleep(20)
     assert unleash_client.is_enabled("testFlag")
+
+
+def test_uc_with_invalid_url():
+    unleash_client = UnleashClient("thisisnotavalidurl", APP_NAME)
+
+    with pytest.raises(ValueError):
+        unleash_client.initialize_client()
+
+
+def test_uc_with_network_error():
+    unleash_client = UnleashClient("https://thisisavalidurl.com", APP_NAME)
+    unleash_client.initialize_client()
+
+    assert unleash_client.is_enabled