Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add request timeout and request retries parameters and override… #270

Conversation

snosratiershad
Copy link
Contributor

… constant value

[related issue] (#264)

I'will check and fill the checklists below soon.

Description

Please include a summary of the change and which issue is fixed (if any).

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests
  • Spec Tests
  • Integration tests / Manual Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@snosratiershad
Copy link
Contributor Author

Looks there is some linting issues from past. please don't merge it until I fix it.

@snosratiershad
Copy link
Contributor Author

I fixed the linting issues and we can merge it now

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@sighphyre sighphyre merged commit df5e0de into Unleash:main Sep 12, 2023
21 checks passed
@kmkr
Copy link

kmkr commented Sep 29, 2023

Fantastic, thanks 🙌 Looking forward to the release of this feature 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants