Skip to content

Commit

Permalink
Refactor code as to make it more readable, maintanable and better fol…
Browse files Browse the repository at this point in the history
…low the ruby style guide

Further linting
  • Loading branch information
rarruda committed Nov 26, 2019
1 parent bc3d3a1 commit cfa384e
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 11 deletions.
24 changes: 14 additions & 10 deletions .rubocop.yml
@@ -1,4 +1,4 @@
inherit_from: .rubocop_todo.yml
# inherit_from: .rubocop_todo.yml

Naming/PredicateName:
NameWhitelist:
Expand All @@ -25,6 +25,7 @@ Metrics/PerceivedComplexity:

Style/Documentation:
Enabled: false

Style/StringLiterals:
Enabled: false
Style/RedundantSelf:
Expand All @@ -38,23 +39,26 @@ Style/PreferredHashMethods:
EnforcedStyle: verbose
Style/FrozenStringLiteralComment:
EnforcedStyle: never
Style/BracesAroundHashParameters:
Enabled: false
Style/GuardClause:
MinBodyLength: 8

Layout/SpaceBeforeBlockBraces:
EnforcedStyle: no_space
Enabled: false

Layout/MultilineMethodCallIndentation:
EnforcedStyle: indented
Style/BracesAroundHashParameters:
Exclude:
- 'spec/**/*.rb'

#
Style/IfInsideElse:
Exclude:
- 'bin/unleash-client'

Style/Next:
Exclude:
- 'lib/unleash/scheduled_executor.rb'

Layout/MultilineMethodCallIndentation:
EnforcedStyle: indented

Layout/SpaceBeforeBlockBraces:
EnforcedStyle: no_space
Exclude:
- 'unleash-client.gemspec'
- 'spec/**/*.rb'
2 changes: 1 addition & 1 deletion lib/unleash/configuration.rb
Expand Up @@ -99,7 +99,7 @@ def initialize_default_logger
end

def merge(opts)
opts.each_pair { |opt, val| set_option(opt, val) }
opts.each_pair{ |opt, val| set_option(opt, val) }
self
end

Expand Down

0 comments on commit cfa384e

Please sign in to comment.