Join threads when shutting down

Unleash · Jan 18, 2019 · e0e0973 · e0e0973
1 parent d3f03fa
commit e0e0973
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/lib/unleash/scheduled_executor.rb b/lib/unleash/scheduled_executor.rb
@@ -46,6 +46,7 @@ def exit
       if self.running?
         Unleash.logger.warn "thread #{name} will exit!"
         self.thread.exit
+        self.thread.join if self.running?
       end
     end
   end

diff --git a/spec/unleash/scheduled_executor_spec.rb b/spec/unleash/scheduled_executor_spec.rb
@@ -12,7 +12,6 @@
 
     expect(scheduled_executor.running?).to be true
     scheduled_executor.exit
-    scheduled_executor.thread.join
     expect(scheduled_executor.running?).to be false
   end
 end