Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing HTTP headers #12

Merged
merged 1 commit into from Oct 25, 2018
Merged

Add missing HTTP headers #12

merged 1 commit into from Oct 25, 2018

Conversation

rarruda
Copy link
Collaborator

@rarruda rarruda commented Oct 25, 2018

This should be a proper fix for #10

@rarruda rarruda requested a review from ivarconr October 25, 2018 07:54
@coveralls
Copy link

Pull Request Test Coverage Report for Build 48

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 42: 0.0%
Covered Lines: 200
Relevant Lines: 200
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 48

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 42: 0.0%
Covered Lines: 200
Relevant Lines: 200
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 25, 2018 •
edited

Pull Request Test Coverage Report for Build 50

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 42: 0.0%
Covered Lines: 200
Relevant Lines: 200
💛 - Coveralls

@rarruda rarruda merged commit 3aeb53b into master Oct 25, 2018
@rarruda rarruda deleted the bugfix/missing_http_headers branch November 13, 2018 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarconr ivarconr ivarconr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rarruda @coveralls @ivarconr