Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update docs, add/improve tests, fix console #132

Merged
merged 1 commit into from Jan 9, 2023

Conversation

rarruda
Copy link
Collaborator

@rarruda rarruda commented Jan 8, 2023

About the changes

  • fixed typos in docs
  • updated docs on use of is_disabled? / disabled? / if_disabled
  • expanded test coverage on new methods above
  • fixed bin/console (only helpful when developing the SDK itself)

@coveralls
Copy link

coveralls commented Jan 8, 2023

Pull Request Test Coverage Report for Build 3873217471

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.4%) to 96.546%

Totals Coverage Status
Change from base Build 3845474547: 4.4%
Covered Lines: 2152
Relevant Lines: 2229

💛 - Coveralls

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

README.md Outdated Show resolved Hide resolved
@rarruda rarruda merged commit 67b1c06 into main Jan 9, 2023
@rarruda rarruda deleted the CHORE/misc_improvements branch January 9, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants