Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove refs to environment in samples, update description #134

Merged
merged 1 commit into from Feb 21, 2023

Conversation

thomasheartman
Copy link
Collaborator

This change removes any references to setting environment in the SDK
config manually.

It also updates the config property description to clarify that it is
not the same as the "Unleash environment".

Why? Because this is a returning point of confusion for our users,

Question

The config option description says "not yet in use". Is still true?

This change removes any references to setting `environment` in the SDK
config manually.

It also updates the config property description to clarify that it is
not the same as the "Unleash environment".

Why? Because this is a returning point of confusion for our users,

## Question

The config option description says "not yet in use". Is still true?
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4231918682

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.5%) to 96.546%

Totals Coverage Status
Change from base Build 4003508808: 4.5%
Covered Lines: 2152
Relevant Lines: 2229

💛 - Coveralls

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pretty sure this is a hangover from the days before we encoded the environment in the API token

@thomasheartman thomasheartman merged commit 82ce1b0 into main Feb 21, 2023
@thomasheartman thomasheartman deleted the docs/environment branch February 21, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants