-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Context#to_h #136
Add Context#to_h #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, nice improvement, LGTM
@tmaier Looks like there's a small bit of formatting Rubocop doesn't like, happy to merge once that's fixed |
Pull Request Test Coverage Report for Build 4524790842
💛 - Coveralls |
Agree! This is definitely nice to have! Should be ok to merge once rubocop is happy. 😊 |
Layout/TrailingWhitespace and Layout/SpaceBeforeBlockBraces cops
I think i've fixed the style errors |
@rarruda I merged your suggestion re. Array#to_h. However, this is only supported for Ruby >= 2.6 |
I should have tested the suggestion on 2.5 before mentioning it. Sorry about the extra work. My bad. Let's revert and we can merge it as it was. |
@rarruda no worries. I removed that last commit. |
@tmaier thanks for your contribution! |
About the changes
Add a
to_h
method to Context.Closes #135