Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: docs: Add Changelog and update docs sections on releasing and contributing (#79) (#94) #144

Conversation

rarruda
Copy link
Collaborator

@rarruda rarruda commented May 23, 2023

About the changes

SSIA

Closes #79 && #94

Discussion points

  1. Would like feedback from the Unleash team regarding the use of Changelog (see Release v4.0.0. What is the braking change? #79 ).

It is only useful if it is kept up-to-date, so it does require a bit more effort in documenting changes. Not sure what is the practice in the other SDKs, or if you guys have opinions regarding this. (maybe referring to the gitlog is a good enough policy?)

Only went back to release 4.0.0 when recreating the changelog history.

  1. Also thought it would be nice to clarify the steps when creating a new release.

Thought it would be nice to have these in place before creating the next release. 🙂

CHANGELOG.md Outdated Show resolved Hide resolved
@rarruda rarruda force-pushed the chore/docs/add_changelog_and_update_releasing_contributing_sections branch from 76ceec1 to e6fdfaf Compare May 23, 2023 23:41
@coveralls
Copy link

coveralls commented May 23, 2023

Pull Request Test Coverage Report for Build 5268590795

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+96.9%) to 96.876%

Totals Coverage Status
Change from base Build 5052083046: 96.9%
Covered Lines: 2419
Relevant Lines: 2497

💛 - Coveralls

@rarruda rarruda force-pushed the chore/docs/add_changelog_and_update_releasing_contributing_sections branch 2 times, most recently from 786cf3f to 8bcd7dd Compare May 23, 2023 23:55
@rarruda rarruda force-pushed the chore/docs/add_changelog_and_update_releasing_contributing_sections branch from 8bcd7dd to b2816ab Compare May 23, 2023 23:56
Copy link
Collaborator

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great! And big kudos for documenting all changes back to v4 🏆

Regarding your questions:

  1. I think having a curated changelog is super useful. Yes, it requires some more work, but I think it's worthwhile. I don't think we have a standard for this anywhere. The closest is Unleash proper, which is moving away from a git log-generated changelog to a manually created one (similar to what you've done here 🙌🏼 ).
  2. Steps on how to create a release are also very much appreciated! Super helpful!

So in other words: I'm very on board with this. It may be that the others have some thoughts on changelogs in other SDKs, though, so we could wait and see what they say 💁🏼

@rarruda
Copy link
Collaborator Author

rarruda commented May 25, 2023

Let's wait for another day then.

I see that the python SDK has also a changelog but follows a different standard. Not sure if standardizing is as important as having it (or not). 🤷

@sighphyre
Copy link
Member

Basically what Thomas says - each SDK has it's own patterns around this (honestly it's own patterns around everything) I don't think they need to remain in lockstep. But I support having a changelog, it's definitely nice for users to be able to find this information without asking so LGTM!

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomasheartman
Copy link
Collaborator

@rarruda Is there anything left to do before merging this? It's been siting around for a bit, so just wanted to check in ☺️

@rarruda
Copy link
Collaborator Author

rarruda commented Jun 14, 2023

There are a couple of changes missing links to their PRs and at least one typo still. Also I've had very little free time lately.

I will try to get this one out very soon so we can have the next release including pr #145 already here.

@thomasheartman
Copy link
Collaborator

Understood! Would you be willing to merge it now and update the remaining links and typos later or would you rather wait to get it fixed? And I'd be happy to put in a description of #145 under either a new 4.4.3 header or the unreleased header. Got any preferences?

@rarruda
Copy link
Collaborator Author

rarruda commented Jun 14, 2023

Feel free to add to the 4.4.3 header since that's coming right around the corner! :)

@thomasheartman
Copy link
Collaborator

Wait, sorry, I'm afraid I've made a mess. It says 4.4.3 was released on May 23, but I don't see that release on rubygems? I added the new stuff under 4.4.4 because 4.4.3 already existed. What's the right course of action here?

@thomasheartman
Copy link
Collaborator

Update: I've gone ahead and done what I suggested. Looks like 4.4.3 was never released, so I've added it there.

@rarruda rarruda merged commit d41c857 into main Jun 14, 2023
41 checks passed
@rarruda rarruda deleted the chore/docs/add_changelog_and_update_releasing_contributing_sections branch June 14, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Release v4.0.0. What is the braking change?
4 participants