Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActivationStrategy - missing parameter in default strategy #18

Merged

Conversation

epicatization
Copy link
Contributor

No description provided.

@epicatization
Copy link
Contributor Author

Hello,
While using default strategy, the response from unleash-server is:

{
  "name"=>"test-flag",
  "description"=>"Test flag.",
  "enabled"=>false,
  "strategies"=>[{"name"=>"default"}],
  "variants"=>nil,
  "createdAt"=>"2019-04-17T06:41:19.140Z"
 }

So based on
https://github.com/Unleash/unleash-client-ruby/blob/4f91fb12eace99ea787050d33b30dc6761d17b8f/lib/unleash/activation_strategy.rb
It will log warning when parameters key is nil.

@epicatization epicatization changed the title Fix warning when params are nil in activation strategy ActivationStrategy - missing parameter in default strategy May 6, 2019
@coveralls
Copy link

coveralls commented May 6, 2019

Pull Request Test Coverage Report for Build 153

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 99.038%

Totals Coverage Status
Change from base Build 137: 0.2%
Covered Lines: 309
Relevant Lines: 312

💛 - Coveralls

@ivarconr ivarconr requested a review from rarruda May 9, 2019 19:56
@rarruda
Copy link
Collaborator

rarruda commented May 14, 2019

Thanks for the contribuition/PR. It looks great!

@rarruda rarruda merged commit 708fd32 into Unleash:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants