Default result always override result when it set as true #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesyang124
force-pushed
the
issues-21
branch
from
99c64c2
to
c4dbb74
Compare
Pull Request Test Coverage Report for Build 174
💛 - Coveralls |
jamesyang124
force-pushed
the
issues-21
branch
from
0c443ee
to
01fc69e
Compare
jamesyang124
force-pushed
the
issues-21
branch
from
01fc69e
to
c63ea62
Compare
…ck as default strategy behaviour
rarruda
requested changes
Sep 5, 2019
rarruda
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After test the result combinations with default result, it does not work as expected when default value is true. It will always override combined result as true regardless the combined result of toggle is enabled and strategy result.
https://github.com/Unleash/unleash-client-ruby/blob/master/lib/unleash/feature_toggle.rb#L74..L81
The modification will be - when strategy result already computed and toggle is enabled, it may respect that combined result instead of default result.