#31 - bugfix: respect retry_limit configuration parameter #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curious, is there a way to say "make infinite retries" by setting this to 0? |
|
Not as is, but that’s very good feedback. Will add feature soon. |
|
After looking a bit more into this, i think it would be more elegant to just specify However I see that it can be useful to document this use case, and will add info in the README. |
rarruda
force-pushed
the
bugfix/31_respect_configured_retry_limit
branch
from
4b7b695
to
d80866e
Compare
configuration setting was never sent to ScheduledExecutor
rarruda
force-pushed
the
bugfix/31_respect_configured_retry_limit
branch
from
d80866e
to
f00639e
Compare
|
Hey guys, @rarruda are you planning to launch a new release with this PR? ty |
|
@orlandojsjr A new release should be coming out soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configuration setting was never sent to ScheduledExecutor