Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing blocks to is_enabled? to determine default_result (#33) #40

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

rarruda
Copy link
Collaborator

@rarruda rarruda commented Mar 22, 2021

This should fix issue #33 .

@rarruda rarruda self-assigned this Mar 22, 2021
@coveralls
Copy link

coveralls commented Mar 22, 2021

Pull Request Test Coverage Report for Build 308

  • 45 of 49 (91.84%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 98.336%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spec/unleash/client_spec.rb 45 49 91.84%
Totals Coverage Status
Change from base Build 285: -0.9%
Covered Lines: 709
Relevant Lines: 721

💛 - Coveralls

@rarruda rarruda force-pushed the feature/default_result_as_blk branch 2 times, most recently from ba2c780 to 4377250 Compare March 26, 2021 23:20
@rarruda rarruda changed the title #33 - allow passing blocks to is_enabled? to determine default_result Allow passing blocks to is_enabled? to determine default_result (#33) May 10, 2021
@rarruda rarruda force-pushed the feature/default_result_as_blk branch 2 times, most recently from 97032a3 to 6aa9a14 Compare May 11, 2021 21:53
@rarruda rarruda requested a review from ivarconr May 18, 2021 12:18
@rarruda rarruda force-pushed the feature/default_result_as_blk branch from 6aa9a14 to ddefe10 Compare June 3, 2021 19:48
spec/unleash/client_spec.rb Outdated Show resolved Hide resolved
spec/unleash/client_spec.rb Outdated Show resolved Hide resolved
- add docs relevant to feature in README
- add unit tests
@rarruda rarruda force-pushed the feature/default_result_as_blk branch from b656177 to 499c642 Compare June 3, 2021 20:42
@rarruda rarruda merged commit b5a4dbb into master Jun 3, 2021
@rarruda rarruda deleted the feature/default_result_as_blk branch June 3, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants