Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: avoid using double slashes in urls #62

Merged
merged 1 commit into from Oct 4, 2021
Merged

Fix: avoid using double slashes in urls #62

merged 1 commit into from Oct 4, 2021

Conversation

rarruda
Copy link
Collaborator

@rarruda rarruda commented Oct 3, 2021

No description provided.

@rarruda rarruda requested a review from ivarconr October 3, 2021 21:58
@coveralls
Copy link

coveralls commented Oct 3, 2021 •
edited

Pull Request Test Coverage Report for Build 1305235515

  • 43 of 43 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.3%) to 95.281%
Totals Coverage Status
Change from base Build 1299048643: 5.3%
Covered Lines: 1373
Relevant Lines: 1441
💛 - Coveralls

@ivarconr
Copy link
Member

ivarconr commented Oct 4, 2021

Nice 👍

@rarruda
fix: avoid double slashes in urls used for API calls.
a10d07c 
- Added relevant unit tests.
- Note: this commit changes behaviour if you have configured a
  base url ending with a single slash.
  If you still want to connect to endpoints with two slashes at the
  end of the baseurl (for whatever reason), then you need to
  terminate the url parameter with two slashes.
@rarruda rarruda force-pushed the fix/avoid_urls_with_double_slashes branch from 0979e78 to a10d07c Compare October 4, 2021 20:44
@rarruda rarruda merged commit 61dd59b into master Oct 4, 2021
@rarruda rarruda deleted the fix/avoid_urls_with_double_slashes branch October 4, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarconr ivarconr ivarconr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rarruda @coveralls @ivarconr