Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make tests pass in context matching #71

Merged
merged 1 commit into from Dec 3, 2021

Conversation

rarruda
Copy link
Collaborator

@rarruda rarruda commented Dec 2, 2021

make it explicit the current state of matching.

It would be good to have this PR merged before #69 as this includes tests for some use-cases that are affected there.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1532841337

  • 0 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 90.235%

Totals Coverage Status
Change from base Build 1530181799: 0.07%
Covered Lines: 1460
Relevant Lines: 1618

💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 2, 2021

Pull Request Test Coverage Report for Build 1532983543

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.2%) to 95.365%

Totals Coverage Status
Change from base Build 1530181799: 5.2%
Covered Lines: 1399
Relevant Lines: 1467

💛 - Coveralls

make it explicit the current state of matching.
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, looks good!

@rarruda rarruda merged commit 6188ed4 into master Dec 3, 2021
@rarruda rarruda deleted the context/additional_tests branch December 3, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants