Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: standardize default values for metrics_interval and retry_limit #78

Merged
merged 1 commit into from Jan 7, 2022
Merged

chore: standardize default values for metrics_interval and retry_limit #78

merged 1 commit into from Jan 7, 2022

Conversation

rarruda
Copy link
Collaborator

@rarruda rarruda commented Dec 16, 2021

to the same values used in the other SDKs

@coveralls
Copy link

coveralls commented Dec 16, 2021 •
edited

Pull Request Test Coverage Report for Build 1589677108

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.2%) to 96.181%
Totals Coverage Status
Change from base Build 1589166825: 5.2%
Covered Lines: 1486
Relevant Lines: 1545
💛 - Coveralls

chriswk
chriswk approved these changes Dec 17, 2021
View reviewed changes
Copy link

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rarruda rarruda merged commit eed0f2d into main Jan 7, 2022
@rarruda rarruda deleted the chore/standardize_config_values branch January 7, 2022 19:21
@rarruda rarruda mentioned this pull request Jan 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarconr ivarconr ivarconr approved these changes

@chriswk chriswk chriswk approved these changes

@FredrikOseberg FredrikOseberg Awaiting requested review from FredrikOseberg

@sighphyre sighphyre Awaiting requested review from sighphyre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rarruda @coveralls @ivarconr @chriswk