Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce #[IsNotEnabled] attribute to complement #[IsEnabled] #33

Merged
merged 1 commit into from Aug 20, 2023

Conversation

Okhoshi
Copy link
Contributor

@Okhoshi Okhoshi commented Aug 17, 2023

Description

The #[IsEnabled] attribute is really helpful but can't help with negated flags, such as kill switches. The #[IsNotEnabled] attribute introduced in this PR aims to fill the need, by just reversing the throwing logic, but keep reusing the infrastructure already in place.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests
  • Spec Tests
  • Integration tests / Manual Tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

NB: I couldn't find the tests in this repo, did I miss something ?

@Okhoshi Okhoshi force-pushed the feat/isnotenabled-attribute branch 2 times, most recently from ad18dff to cd57d1e Compare August 17, 2023 08:12
Copy link
Collaborator

@RikudouSage RikudouSage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Overall looks good, though I requested some changes, most of them are for consistency.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/Attribute/ControllerAttribute.php Outdated Show resolved Hide resolved
src/Attribute/IsEnabled.php Outdated Show resolved Hide resolved
src/Attribute/IsNotEnabled.php Outdated Show resolved Hide resolved
src/Listener/ControllerAttributeResolver.php Outdated Show resolved Hide resolved
src/Attribute/ControllerAttribute.php Show resolved Hide resolved
src/Attribute/IsEnabled.php Show resolved Hide resolved
src/Attribute/IsNotEnabled.php Show resolved Hide resolved
src/Attribute/IsNotEnabled.php Outdated Show resolved Hide resolved
Signed-off-by: Quentin Devos <4972091+Okhoshi@users.noreply.github.com>
Copy link
Collaborator

@RikudouSage RikudouSage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! I'll do a re-review tomorrow when I'm less tired but so far I can't find anything wrong with it.

Copy link
Collaborator

@RikudouSage RikudouSage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll be releasing this tomorrow.

@RikudouSage RikudouSage merged commit f0e5223 into Unleash:main Aug 20, 2023
2 checks passed
@Okhoshi Okhoshi deleted the feat/isnotenabled-attribute branch August 21, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants