Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Update codebase to php 8.2 #38

Merged
merged 3 commits into from Aug 25, 2023
Merged

Chore: Update codebase to php 8.2 #38

merged 3 commits into from Aug 25, 2023

Conversation

RikudouSage
Copy link
Collaborator

@RikudouSage RikudouSage commented Aug 24, 2023 •
edited

Description

Updates the codebase (and tooling to downgrade for older versions).

How Has This Been Tested?

  • Manual Tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@RikudouSage RikudouSage marked this pull request as ready for review August 24, 2023 10:15
sighphyre
sighphyre approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't know this project very well but this looks pretty sane

@RikudouSage RikudouSage merged commit aa360de into main Aug 25, 2023
2 checks passed
@RikudouSage RikudouSage deleted the chore/update-php branch August 25, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighphyre sighphyre sighphyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RikudouSage @sighphyre