Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Always provide bootstrap provider #47

Merged
merged 1 commit into from Nov 28, 2023
Merged

Fix: Always provide bootstrap provider #47

merged 1 commit into from Nov 28, 2023

Conversation

RikudouSage
Copy link
Collaborator

Description

Bootstrap provider is now a mandatory parameter in v2 of Unleash SDK, thus it needs to always be provided.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Manual Tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

sighphyre
sighphyre approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RikudouSage RikudouSage merged commit 72ef334 into main Nov 28, 2023
3 checks passed
@RikudouSage RikudouSage deleted the fix/always-provide-bootstrap branch November 28, 2023 11:53
@RikudouSage RikudouSage mentioned this pull request Nov 28, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighphyre sighphyre sighphyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RikudouSage @sighphyre