Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add support for DSN #57

Merged
merged 5 commits into from Jan 19, 2024
Merged

Feat: Add support for DSN #57

merged 5 commits into from Jan 19, 2024

Conversation

RikudouSage
Copy link
Collaborator

@RikudouSage RikudouSage commented Jan 17, 2024 •
edited

Description

Adds support for creating the basic parameters from a DSN instead of separate parameters.

Fixes #50

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Manual Tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

sighphyre
sighphyre approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RikudouSage RikudouSage merged commit c4a88d4 into main Jan 19, 2024
2 checks passed
@RikudouSage RikudouSage deleted the feat/dsn branch January 19, 2024 10:11
@dkarlovi
Copy link

@RikudouSage thank you for these features! <3

@dkarlovi dkarlovi mentioned this pull request Mar 4, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighphyre sighphyre sighphyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: use a DSN for credentials
3 participants
@RikudouSage @dkarlovi @sighphyre