Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

New project page header #1207

Merged
merged 3 commits into from
Aug 8, 2022
Merged

New project page header #1207

merged 3 commits into from
Aug 8, 2022

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Aug 5, 2022 •
edited

  1. Added description to header
  2. Added projectId to header
  3. Added possiblity to delete project (Created reusable component)

@vercel
Copy link

vercel bot commented Aug 5, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
unleash-frontend ✅ Ready (Inspect) Visit Preview Aug 8, 2022 at 7:49AM (UTC)

nunogois
nunogois suggested changes Aug 5, 2022
View reviewed changes
Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but as usual some small nitpicks and comments that might be worth checking out before merging.

src/component/project/Project/DeleteProject/DeleteProjectDialogue.tsx Outdated Show resolved Hide resolved
src/component/project/Project/DeleteProject/DeleteProjectDialogue.tsx Outdated Show resolved Hide resolved
src/component/project/Project/DeleteProject/DeleteProjectDialogue.tsx Outdated Show resolved Hide resolved
src/component/project/Project/Project.tsx Outdated Show resolved Hide resolved
src/component/project/Project/Project.tsx Outdated Show resolved Hide resolved
src/component/project/Project/Project.tsx Outdated Show resolved Hide resolved
src/component/project/Project/Project.tsx Outdated Show resolved Hide resolved
src/component/project/ProjectCard/ProjectCard.tsx Show resolved Hide resolved
src/component/project/Project/DeleteProject/DeleteProjectDialogue.tsx Show resolved Hide resolved
@sjaanus sjaanus self-assigned this Aug 8, 2022
@sjaanus sjaanus requested a review from nunogois August 8, 2022 07:47
nunogois
nunogois approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjaanus sjaanus merged commit ab5df41 into main Aug 8, 2022
@sjaanus sjaanus deleted the jaanus/2-50-improve-project-page-header-to-look-like branch August 8, 2022 09:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nunogois nunogois nunogois approved these changes

Assignees

@sjaanus sjaanus

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sjaanus @nunogois