Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

fix: remove group owner concept #1210

Merged
merged 15 commits into from
Aug 11, 2022
Merged

fix: remove group owner concept #1210

merged 15 commits into from
Aug 11, 2022

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Aug 8, 2022

@vercel
Copy link

vercel bot commented Aug 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
unleash-frontend ✅ Ready (Inspect) Visit Preview Aug 11, 2022 at 2:28PM (UTC)

@sighphyre
Copy link
Member

This depends on: Unleash/unleash#1905 which is probably why the group tests are failing

Copy link
Contributor

@sjaanus sjaanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Made some minor suggestions for clarity.

src/component/admin/groups/CreateGroup/CreateGroup.tsx Outdated Show resolved Hide resolved
src/component/admin/groups/EditGroup/EditGroup.tsx Outdated Show resolved Hide resolved
@nunogois nunogois merged commit 688f8cd into main Aug 11, 2022
@nunogois nunogois deleted the fix-remove-group-owner-concept branch August 11, 2022 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants