Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

Fix/playground virtualisation loader #1214

Merged
merged 6 commits into from
Aug 11, 2022

Conversation

andreas-unleash
Copy link
Contributor

@andreas-unleash andreas-unleash commented Aug 10, 2022

Fixes:

  • Displays loader when api is loading
  • Use VirtualisedTable (list virtualisation) for the results

About the changes

Closes # .

Relates to Unleash/unleash#1873

Important files

Discussion points

@vercel
Copy link

vercel bot commented Aug 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
unleash-frontend ✅ Ready (Inspect) Visit Preview Aug 10, 2022 at 0:33AM (UTC)

@FredrikOseberg
Copy link
Contributor

FredrikOseberg commented Aug 10, 2022

Could we update the description here and add the issue reference?

@@ -18,6 +18,7 @@ import {
} from './playground.utils';
import { PlaygroundGuidance } from './PlaygroundGuidance/PlaygroundGuidance';
import { PlaygroundGuidancePopper } from './PlaygroundGuidancePopper/PlaygroundGuidancePopper';
import Loader from '../../common/Loader/Loader';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

component/... ?

@andreas-unleash andreas-unleash merged commit 96639d7 into main Aug 11, 2022
@andreas-unleash andreas-unleash deleted the fix/playground_virtualisation_loader branch August 11, 2022 07:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants