Fix/revert browser field (#115)

* fix: remove browser field * fix: do not emit error for 304
Unleash · Sep 23, 2022 · 516660a · 516660a
1 parent 8ad5707
commit 516660a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -4,7 +4,6 @@
   "description": "A browser client that can be used together with the unleash-proxy.",
   "main": "./build/index.js",
   "types": "./build/index.d.ts",
-  "browser": "./build/main.min.js",
   "files": [
     "build",
     "examples",

diff --git a/src/index.ts b/src/index.ts
@@ -368,9 +368,14 @@ export class UnleashClient extends TinyEmitter {
                         this.emit(EVENTS.READY);
                         this.readyEventEmitted = true;
                     }
-                } else if (!response.ok) {
-                    console.error('Unleash: Fetching feature toggles did not have an ok response');
-                    this.emit(EVENTS.ERROR, { type: 'HttpError', code: response.status })
+                } else if (!response.ok && response.status !== 304) {
+                    console.error(
+                        'Unleash: Fetching feature toggles did not have an ok response'
+                    );
+                    this.emit(EVENTS.ERROR, {
+                        type: 'HttpError',
+                        code: response.status,
+                    });
                 }
             } catch (e) {
                 console.error('Unleash: unable to fetch feature toggles', e);