Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge sessionId instead of removing it #119

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Conversation

ivarconr
Copy link
Member

About the changes

It is unexpected for "uppdateContext" to remove
the automatically generated sessionId. This fix keeps the sessionId as long as it is not specified in the new context passed in to the "updateContext" method.

Closes #118

It is unexpected for "uppdateContext" to remove
the automatically generated sessionId. This fix keeps the
sessionId as long as it is not specified in the new
context passed in to the "updateContext" method.

fixes: #118
Copy link
Contributor

@andreas-unleash andreas-unleash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivarconr ivarconr merged commit 2262f74 into main Oct 6, 2022
@ivarconr ivarconr deleted the fix/merge-session-id branch October 6, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

updateContext overrides the generated session id.
2 participants