Upgrade #155
Merged
Upgrade #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastonfournier
approved these changes
Jun 13, 2023
| "build:web": "rollup -c rollup.config.js", | ||
| "fmt": "prettier src --write --loglevel warn", | ||
| "lint": "eslint src", | ||
| "build": "rm -rf build && tsc && rollup -c rollup.config.mjs", |
There was a problem hiding this comment.
Nit: Here the build is doing a clean & build, which seems like two different steps, but for CI/CD it doesn't matter much because build folder will not exist
There was a problem hiding this comment.
rm -f will not cause an error if the target doesn't exist
| // "allowJs": true, /* Allow javascript files to be compiled. */ | ||
| // "checkJs": true, /* Report errors in .js files. */ | ||
| // "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */ | ||
| "declaration": true, /* Generates corresponding '.d.ts' file. */ | ||
| "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */ | ||
| "sourceMap": true, /* Generates corresponding '.map' file. */ | ||
| // "outFile": "./", /* Concatenate and emit output to single file. */ | ||
| "outDir": "./build", /* Redirect output structure to the directory. */ | ||
| "outDir": "build/cjs", /* Redirect output structure to the directory. */ |
There was a problem hiding this comment.
Have you tested importing this as a library? These changes tend to be tricky
There was a problem hiding this comment.
Yes. Tested both in CJS and ESM setup (require & import)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
This will require major version bump, because of dropped Node v12 support.
Closes #1-951
Important files