Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup controller #109

Merged
merged 10 commits into from
Mar 9, 2023
Merged

fix: cleanup controller #109

merged 10 commits into from
Mar 9, 2023

Conversation

ivarconr
Copy link
Member

This cleanup aims to reduce duplication in the main controller of the proxy by using middlewares for two things:

  1. Validate proxy is ready to handle requests
  2. Resolve the context (and enrich it with custom enrichers)

/cc @LukasHeimann

gastonfournier
gastonfournier approved these changes Dec 26, 2022
View reviewed changes
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a small note that we can discuss later

src/unleash-proxy.ts Show resolved Hide resolved
@stale
Copy link

stale bot commented Jan 25, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 25, 2023
LukasHeimann
LukasHeimann reviewed Jan 26, 2023
View reviewed changes
Copy link

@LukasHeimann LukasHeimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was notified about this being stale and had a look again

src/unleash-proxy.ts Show resolved Hide resolved
src/context-middleware.ts Outdated Show resolved Hide resolved
@stale stale bot removed stale labels Jan 26, 2023
@LukasHeimann LukasHeimann mentioned this pull request Jan 26, 2023
Open
@stale
Copy link

stale bot commented Feb 25, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 25, 2023
@stale stale bot closed this Mar 7, 2023
@LukasHeimann
Copy link

Will this be picked up again?

@gastonfournier gastonfournier reopened this Mar 7, 2023
@stale stale bot removed stale labels Mar 7, 2023
gastonfournier and others added 2 commits March 7, 2023 17:18
@gastonfournier
Explicitly refer to client tokens
616881c
@ivarconr @LukasHeimann
Update src/context-middleware.ts
6694bba 
Co-authored-by: LukasHeimann <48723560+LukasHeimann@users.noreply.github.com>
@ivarconr ivarconr merged commit 90529c5 into main Mar 9, 2023
@ivarconr ivarconr deleted the fix/cleanup-controller branch March 9, 2023 15:08
@ivarconr
Copy link
Member Author

was released as part of unleash-proxy v0.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHeimann LukasHeimann LukasHeimann left review comments

@gastonfournier gastonfournier gastonfournier approved these changes

@chriswk chriswk Awaiting requested review from chriswk

@FredrikOseberg FredrikOseberg Awaiting requested review from FredrikOseberg

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivarconr @LukasHeimann @gastonfournier