Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in readme #24

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Fix typos in readme #24

merged 1 commit into from
Apr 22, 2023

Conversation

sberlin
Copy link
Contributor

@sberlin sberlin commented Apr 19, 2023

About the changes

  1. documented YAML configuration cannot work, because the auto-configuration defines the prefix io.getunleash instead of io.getunleashed
  2. documented code example for bean of unleashContextProvider does not compile, because of one opening parenthesis too much.

thomasheartman
thomasheartman approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks right to me, at least. Nice catch! 😄 I'm def gonna want @chriswk to have a peek before getting it in, though.

@praveenpg praveenpg merged commit 2ceccc9 into Unleash:main Apr 22, 2023
2 checks passed
@sberlin sberlin deleted the fix/typos branch May 2, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasheartman thomasheartman thomasheartman approved these changes

@chriswk chriswk Awaiting requested review from chriswk

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sberlin @thomasheartman @praveenpg