Skip to content

Commit

Permalink
task: Make /edge/metrics toggleable by toggle (#6003)
Browse files Browse the repository at this point in the history
Previously we used a killswitch and returned 404 if the feature was
enabled. This flips that to a default disabled toggle, that has to be
turned on to handle old Edge (pre 17.0.0) posting bulk metrics
  • Loading branch information
Christopher Kolstad committed Jan 24, 2024
1 parent 1f7c794 commit 3acdfc2
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/lib/__snapshots__/create-config.test.ts.snap
Expand Up @@ -85,7 +85,7 @@ exports[`should create default config 1`] = `
"disableBulkToggle": false,
"disableMetrics": false,
"disableNotifications": false,
"edgeBulkMetricsKillSwitch": false,
"edgeBulkMetrics": false,
"embedProxy": true,
"embedProxyFrontend": true,
"enableLicense": false,
Expand Down
2 changes: 1 addition & 1 deletion src/lib/routes/edge-api/index.ts
Expand Up @@ -118,7 +118,7 @@ export default class EdgeController extends Controller {
req: IAuthRequest<void, void, BulkMetricsSchema>,
res: Response<void>,
): Promise<void> {
if (!this.flagResolver.isEnabled('edgeBulkMetricsKillSwitch')) {
if (this.flagResolver.isEnabled('edgeBulkMetrics')) {
const { body, ip: clientIp } = req;
const { metrics, applications } = body;

Expand Down
6 changes: 3 additions & 3 deletions src/lib/types/experimental.ts
Expand Up @@ -40,7 +40,7 @@ export type IFlagKey =
| 'featureSearchFeedback'
| 'featureSearchFeedbackPosting'
| 'newStrategyConfigurationFeedback'
| 'edgeBulkMetricsKillSwitch'
| 'edgeBulkMetrics'
| 'extendedUsageMetrics'
| 'extendedUsageMetricsUI'
| 'adminTokenKillSwitch'
Expand Down Expand Up @@ -185,8 +185,8 @@ const flags: IFlags = {
process.env.UNLEASH_EXPERIMENTAL_ENCRYPT_EMAILS,
false,
),
edgeBulkMetricsKillSwitch: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_EDGE_BULK_METRICS_KILL_SWITCH,
edgeBulkMetrics: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_EDGE_BULK_METRICS,
false,
),
extendedUsageMetrics: parseEnvVarBoolean(
Expand Down

0 comments on commit 3acdfc2

Please sign in to comment.