fix: move outdated sdks check up (#6725)

Unleash · Mar 28, 2024 · c12cb42 · c12cb42
1 parent ca6946d
commit c12cb42
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/frontend/src/component/App.tsx b/frontend/src/component/App.tsx
@@ -23,6 +23,7 @@ import { EdgeUpgradeBanner } from './banners/EdgeUpgradeBanner/EdgeUpgradeBanner
 import { LicenseBanner } from './banners/internalBanners/LicenseBanner';
 import { Demo } from './demo/Demo';
 import { OutdatedSdksBanner } from './banners/OutdatedSdksBanner/OutdatedSdksBanner';
+import { useUiFlag } from '../hooks/useUiFlag';
 
 const StyledContainer = styled('div')(() => ({
     '& ul': {
@@ -49,6 +50,8 @@ export const App = () => {
         }
     }, [authDetails, user]);
 
+    const outdatedSdksBannerEnabled = useUiFlag('outdatedSdksBanner');
+
     return (
         <SWRProvider>
             <Suspense fallback={<Loader />}>
@@ -68,6 +71,10 @@ export const App = () => {
                                 <ExternalBanners />
                                 <InternalBanners />
                                 <EdgeUpgradeBanner />
+                                <ConditionallyRender
+                                    condition={outdatedSdksBannerEnabled}
+                                    show={<OutdatedSdksBanner />}
+                                />
                                 <OutdatedSdksBanner />
                                 <StyledContainer>
                                     <ToastRenderer />

diff --git a/frontend/src/component/banners/OutdatedSdksBanner/OutdatedSdksBanner.tsx b/frontend/src/component/banners/OutdatedSdksBanner/OutdatedSdksBanner.tsx
@@ -2,7 +2,6 @@ import { ConditionallyRender } from 'component/common/ConditionallyRender/Condit
 import { Banner } from '../Banner/Banner';
 import type { IBanner } from 'interfaces/banner';
 import { useOutdatedSdks } from 'hooks/api/getters/useOutdatedSdks/useOutdatedSdks';
-import { useUiFlag } from 'hooks/useUiFlag';
 import { Link } from 'react-router-dom';
 import { styled } from '@mui/material';
 import { usePlausibleTracker } from 'hooks/usePlausibleTracker';
@@ -13,7 +12,6 @@ export const OutdatedSdksBanner = () => {
     const {
         data: { sdks },
     } = useOutdatedSdks();
-    const flagEnabled = useUiFlag('outdatedSdksBanner');
     const { trackEvent } = usePlausibleTracker();
 
     const applicationClickedWithVersion = (sdkVersion: string) => {
@@ -74,7 +72,7 @@ export const OutdatedSdksBanner = () => {
     return (
         <>
             <ConditionallyRender
-                condition={flagEnabled && sdks.length > 0}
+                condition={sdks.length > 0}
                 show={<Banner banner={outdatedSdksBanner} />}
             />
         </>