chore: remove new frontend api feature flag (#6906)

The flag has been 100% for a bit now, we need to prepare for GA.
Unleash · Apr 24, 2024 · d578dea · d578dea
1 parent bf33664
commit d578dea
Show file tree

Hide file tree

Showing 10 changed files with 29 additions and 466 deletions.
diff --git a/src/lib/__snapshots__/create-config.test.ts.snap b/src/lib/__snapshots__/create-config.test.ts.snap
@@ -121,7 +121,6 @@ exports[`should create default config 1`] = `
         },
       },
       "filterInvalidClientMetrics": false,
-      "globalFrontendApiCache": false,
       "googleAuthEnabled": false,
       "inMemoryScheduledChangeRequests": false,
       "maintenanceMode": false,
@@ -144,7 +143,6 @@ exports[`should create default config 1`] = `
       "queryMissingTokens": false,
       "responseTimeMetricsFix": false,
       "responseTimeWithAppNameKillSwitch": false,
-      "returnGlobalFrontendApiCache": false,
       "scimApi": false,
       "showInactiveUsers": false,
       "signals": false,

diff --git a/src/lib/features/frontend-api/frontend-api-controller.ts b/src/lib/features/frontend-api/frontend-api-controller.ts
@@ -10,7 +10,6 @@ import {
     emptyResponse,
     getStandardResponses,
     type FrontendApiClientSchema,
-    type FrontendApiFeatureSchema,
     frontendApiFeaturesSchema,
     type FrontendApiFeaturesSchema,
 } from '../../openapi';
@@ -21,8 +20,6 @@ import NotImplementedError from '../../error/not-implemented-error';
 import NotFoundError from '../../error/notfound-error';
 import rateLimit from 'express-rate-limit';
 import { minutesToMilliseconds } from 'date-fns';
-import isEqual from 'lodash.isequal';
-import { diff } from 'json-diff';
 import metricsHelper from '../../util/metrics-helper';
 import { FUNCTION_TIME } from '../../metric-events';
 
@@ -186,48 +183,11 @@ export default class FrontendAPIController extends Controller {
         if (!this.config.flagResolver.isEnabled('embedProxy')) {
             throw new NotFoundError();
         }
-        let toggles: FrontendApiFeatureSchema[];
-        let newToggles: FrontendApiFeatureSchema[] = [];
-        if (this.config.flagResolver.isEnabled('globalFrontendApiCache')) {
-            const context = FrontendAPIController.createContext(req);
-            [toggles, newToggles] = await Promise.all([
-                this.getTimedFrontendApiFeatures(req, context),
-                this.getTimedNewFrontendApiFeatures(req, context),
-            ]);
-            const sortedToggles = toggles.sort((a, b) =>
-                a.name.localeCompare(b.name),
-            );
-            const sortedNewToggles = newToggles.sort((a, b) =>
-                a.name.localeCompare(b.name),
+        const toggles =
+            await this.services.frontendApiService.getFrontendApiFeatures(
+                req.user,
+                FrontendAPIController.createContext(req),
             );
-            if (!isEqual(sortedToggles, sortedNewToggles)) {
-                this.logger.warn(
-                    `old features and new features are different. Old count ${
-                        toggles.length
-                    }, new count ${newToggles.length}, projects ${
-                        req.user.projects
-                    }, environment ${
-                        req.user.environment
-                    }, diff ${JSON.stringify(
-                        diff(sortedToggles, sortedNewToggles),
-                    )}`,
-                );
-            }
-        } else if (
-            this.config.flagResolver.isEnabled('returnGlobalFrontendApiCache')
-        ) {
-            toggles =
-                await this.services.frontendApiService.getNewFrontendApiFeatures(
-                    req.user,
-                    FrontendAPIController.createContext(req),
-                );
-        } else {
-            toggles =
-                await this.services.frontendApiService.getFrontendApiFeatures(
-                    req.user,
-                    FrontendAPIController.createContext(req),
-                );
-        }
 
         res.set('Cache-control', 'no-cache');
 
@@ -239,28 +199,6 @@ export default class FrontendAPIController extends Controller {
         );
     }
 
-    private async getTimedFrontendApiFeatures(req, context) {
-        const stopTimer = this.timer('getFrontendApiFeatures');
-        const features =
-            await this.services.frontendApiService.getFrontendApiFeatures(
-                req.user,
-                context,
-            );
-        stopTimer();
-        return features;
-    }
-
-    private async getTimedNewFrontendApiFeatures(req, context) {
-        const stopTimer = this.timer('getNewFrontendApiFeatures');
-        const features =
-            await this.services.frontendApiService.getNewFrontendApiFeatures(
-                req.user,
-                context,
-            );
-        stopTimer();
-        return features;
-    }
-
     private async registerFrontendApiMetrics(
         req: ApiUserRequest<unknown, unknown, ClientMetricsSchema>,
         res: Response,

diff --git a/src/lib/features/frontend-api/frontend-api-repository.ts b/src/lib/features/frontend-api/frontend-api-repository.ts
@@ -49,7 +49,6 @@ export class FrontendApiRepository
     }
 
     getToggle(name: string): FeatureInterface {
-        //@ts-ignore (we must update the node SDK to allow undefined)
         return this.globalFrontendApiCache.getToggle(name, this.token);
     }
 

diff --git a/src/lib/features/frontend-api/frontend-api-service.e2e.test.ts b/src/lib/features/frontend-api/frontend-api-service.e2e.test.ts
diff --git a/src/lib/features/frontend-api/frontend-api-service.test.ts b/src/lib/features/frontend-api/frontend-api-service.test.ts
@@ -52,7 +52,7 @@ test('frontend api service fetching features from global cache', async () => {
         globalFrontendApiCache,
     );
 
-    const features = await frontendApiService.getNewFrontendApiFeatures(
+    const features = await frontendApiService.getFrontendApiFeatures(
         {
             projects: ['irrelevant'],
             environment: 'irrelevant',