fix: add segment to strategy payload (#3611)

Unleash · Apr 25, 2023 · e538cb8 · e538cb8
1 parent 8fdb152
commit e538cb8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/...end/src/component/feature/FeatureStrategy/FeatureStrategyCreate/FeatureStrategyCreate.tsx b/...end/src/component/feature/FeatureStrategy/FeatureStrategyCreate/FeatureStrategyCreate.tsx
@@ -114,9 +114,9 @@ export const FeatureStrategyCreate = () => {
         refetchChangeRequests();
     };
 
-    const onSubmit = async () => {
-        const payload = createStrategyPayload(strategy, segments);
+    const payload = createStrategyPayload(strategy, segments);
 
+    const onSubmit = async () => {
         trackEvent('strategyTitle', {
             props: {
                 hasTitle: Boolean(strategy.title),
@@ -153,7 +153,7 @@ export const FeatureStrategyCreate = () => {
                     projectId,
                     featureId,
                     environmentId,
-                    strategy,
+                    payload,
                     unleashUrl
                 )
             }

diff --git a/frontend/src/component/feature/FeatureStrategy/FeatureStrategyEdit/FeatureStrategyEdit.tsx b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyEdit/FeatureStrategyEdit.tsx
@@ -94,6 +94,9 @@ export const FeatureStrategyEdit = () => {
         savedStrategySegments && setSegments(savedStrategySegments);
     }, [JSON.stringify(savedStrategySegments)]);
 
+    const segmentsToSubmit = uiConfig?.flags.SE ? segments : [];
+    const payload = createStrategyPayload(strategy, segmentsToSubmit);
+
     const onStrategyEdit = async (payload: IFeatureStrategyPayload) => {
         await updateStrategyOnFeature(
             projectId,
@@ -134,9 +137,6 @@ export const FeatureStrategyEdit = () => {
     };
 
     const onSubmit = async () => {
-        const segmentsToSubmit = uiConfig?.flags.SE ? segments : [];
-        const payload = createStrategyPayload(strategy, segmentsToSubmit);
-
         try {
             if (isChangeRequestConfigured(environmentId)) {
                 await onStrategyRequestEdit(payload);
@@ -168,7 +168,7 @@ export const FeatureStrategyEdit = () => {
                     projectId,
                     featureId,
                     environmentId,
-                    strategy,
+                    payload,
                     strategyDefinition,
                     unleashUrl
                 )