Suggestions for some method signature changes

[ByungjunYou]

After reading the below code in feature-toggle-strategies-store.ts, I was confused with some method signatures.

I think the return type of getFeatureOverviewData should be Record<string, IFeatureOverview> instead of IFeatureOverview. Because acc[row.feature_name] = { type: ..., description: ... } suggests that acc is a record whose key is string type and value is IFeatureOverview type.

unleash/src/lib/features/feature-toggle/feature-toggle-strategies-store.ts

Lines 731 to 777 in 79fcfc2

	getFeatureOverviewData(rows): IFeatureOverview {
	return rows.reduce((acc, row) => {
	if (acc[row.feature_name]) {
	const environmentExists = acc[
	row.feature_name
	].environments.some(
	(existingEnvironment) =>
	existingEnvironment.name === row.environment,
	);
	if (!environmentExists) {
	acc[row.feature_name].environments.push(
	FeatureStrategiesStore.getEnvironment(row),
	);
	}
	if (this.isNewTag(acc[row.feature_name], row)) {
	this.addTag(acc[row.feature_name], row);
	}
	} else {
	acc[row.feature_name] = {
	type: row.type,
	description: row.description,
	favorite: row.favorite,
	name: row.feature_name,
	createdAt: row.created_at,
	stale: row.stale,
	impressionData: row.impression_data,
	lastSeenAt: row.last_seen_at,
	environments: [FeatureStrategiesStore.getEnvironment(row)],
	};
	if (this.isNewTag(acc[row.feature_name], row)) {
	this.addTag(acc[row.feature_name], row);
	}
	}
	const featureRow = acc[row.feature_name];
	if (
	isAfter(
	new Date(row.env_last_seen_at),
	new Date(featureRow.lastSeenAt),
	)
	) {
	featureRow.lastSeenAt = row.env_last_seen_at;
	}
	return acc;
	}, {});
	}

unleash/src/lib/types/model.ts

Lines 208 to 220 in 283a8f4

	export interface IFeatureOverview {
	name: string;
	description: string;
	project: string;
	favorite: boolean;
	impressionData: boolean;
	segments: string[];
	type: string;
	stale: boolean;
	createdAt: Date;
	lastSeenAt: Date;
	environments: IEnvironmentOverview[];
	}

In case of the parameter type of sortEnvironments, it also might be correct to use Record<string, IFeatureOverview>. Since Object.values(overview).map((data: IFeatureOverview) strongly suggest that overview is a record whose value is IFeatureOverview type.

unleash/src/lib/features/feature-toggle/feature-toggle-strategies-store.ts

Lines 108 to 120 in 5335422

	const sortEnvironments = (overview: IFeatureOverview) => {
	return Object.values(overview).map((data: IFeatureOverview) => ({
	...data,
	environments: data.environments
	.filter((f) => f.name)
	.sort((a, b) => {
	if (a.sortOrder === b.sortOrder) {
	return a.name.localeCompare(b.name);
	}
	return a.sortOrder - b.sortOrder;
	}),
	}));
	};

If the suggestions make sense to you, I'm also open to make a PR for the fix. :)

[sjaanus]

Good catch, addressed it here #6750

[ByungjunYou]

@sjaanus
Thank you for the fix :)