Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info about UNLEASH_PROXY_SECRETS and client keys #1161

Merged
merged 8 commits into from Dec 6, 2021

Conversation

thomasheartman
Copy link
Contributor

This PR adds more information about what UNLEASH_PROXY_SECRETS and client keys are.

To the proxy docs I have added a description of what the configuration variables are and how they are used. To the client SDK docs, I have added more information about how the clients are configured and what the configuration values are.

I have also slightly restructured the docs where appropriate and added some extra syntax highlighting.

@vercel
Copy link

vercel bot commented Dec 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/unleash-team/unleash-docs/7z9xReC2vr6jL66ve9BEjHvCtXLX
✅ Preview: https://unleash-docs-git-docs-unleashproxysecrets-a-6a83d6-unleash-team.vercel.app

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟢 Statements 92.06% 4799/5213
🟢 Branches 82.07% 975/1188
🟢 Functions 87.93% 1144/1301
🟢 Lines 93.67% 5338/5699

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from b595277

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I have a very small spelling/grammar things, feel free to discard or ignore

website/docs/sdks/android-proxy.md Outdated Show resolved Hide resolved
website/docs/sdks/android-proxy.md Outdated Show resolved Hide resolved
website/docs/sdks/proxy-ios.md Outdated Show resolved Hide resolved
website/docs/sdks/proxy-javascript.md Outdated Show resolved Hide resolved
website/docs/sdks/proxy-ios.md Outdated Show resolved Hide resolved
website/docs/sdks/unleash-proxy.md Outdated Show resolved Hide resolved
Co-authored-by: sighphyre <liquidwicked64@gmail.com>
@thomasheartman
Copy link
Contributor Author

Sweet; thanks! Much appreciated 🙌🏼 I've accepted all but one of them (for list styling consistency). I'll go ahead and merge when it's ready 🚂

@thomasheartman thomasheartman merged commit 2c97427 into master Dec 6, 2021
@thomasheartman thomasheartman deleted the docs/UNLEASH_PROXY_SECRETS-and-clientKey branch December 15, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants