New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: open validate endpoint #1162
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/unleash-team/unleash-docs/BC6B9y8eXuusQzU9qXNxwaF9V6UF |
src/lib/routes/admin-api/feature.ts
Outdated
@@ -44,7 +44,7 @@ class FeatureController extends Controller { | |||
this.get('/:featureName', this.getToggle); | |||
this.put('/:featureName', this.updateToggle, UPDATE_FEATURE); | |||
this.delete('/:featureName', this.archiveToggle, DELETE_FEATURE); | |||
this.post('/validate', this.validate, UPDATE_FEATURE); | |||
this.post('/validate', this.validate); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should use NONE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/lib/routes/controller.ts
Outdated
@@ -72,7 +72,7 @@ export default class Controller { | |||
post( | |||
path: string, | |||
handler: IRequestHandler, | |||
permission: string, | |||
permission?: string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't do this, use NONE instead!
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from a56ed03 |
No description provided.