fix(docs/a11y): fix lack of contrast in on hovered links in footer #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the hover color of links in the footer to keep it accessible. The color will be the exact same as the un-hovered version. This is in line with the other links in the documentation. The links _do_ get underlined when hovered, so there is still a visual distinction between the states. I've added the variable in the `footer` section instead of in `:root` because the variable I assign it to (`--ifm-footer-link-color`) gets overridden closer to the footer, so if you set it in `:root`, you end up with the wrong value. addresses and closes https://github.com/Unleash/unleash.github.io/issues/8
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/unleash-team/unleash-docs/HDpRTRYwhxJKv2D2TtF232zhX4MM |
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from 4899eff |
sighphyre
approved these changes
Jan 18, 2022
thomasheartman
added a commit
that referenced
this pull request
Jan 24, 2022
commit da2b165 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 24 11:58:02 2022 +0100 fix(deps): update dependency knex to v1 (#1272) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 59cd88d Author: Dtaggart <Dustin.Taggart@live.com> Date: Mon Jan 24 03:27:50 2022 -0500 docs: Update getting-started.md (#1294) Correct password spelling. Was missing w commit 0af2270 Author: Renovate Bot <bot@renovateapp.com> Date: Sun Jan 23 22:14:53 2022 +0000 chore(deps): update dependency lint-staged to v12.3.1 commit 8a175aa Author: Ivar Conradi Østhus <ivarconr@gmail.com> Date: Sun Jan 23 22:50:39 2022 +0100 docs: update Server-side SDK compatibility table commit 72e053f Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Jan 23 21:58:36 2022 +0100 chore(deps): pin dependency @types/type-is to 1.6.3 (#1285) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 14a305f Author: Ivar Conradi Østhus <ivarconr@gmail.com> Date: Sun Jan 23 21:26:28 2022 +0100 fix: upgrade node-fetch to version 2.6.7 commit 2fbbe51 Author: Renovate Bot <bot@renovateapp.com> Date: Sun Jan 23 02:34:42 2022 +0000 chore(deps): update dependency @babel/core to v7.16.12 commit 69a6f5c Author: Renovate Bot <bot@renovateapp.com> Date: Fri Jan 21 21:35:00 2022 +0000 fix(deps): update dependency log4js to v6.4.0 [security] commit baa0966 Author: Fredrik Oseberg <fredrik.no@gmail.com> Date: Fri Jan 21 16:20:29 2022 +0100 4.6.0-beta.8 commit 01cd4eb Author: Fredrik Oseberg <fredrik.no@gmail.com> Date: Fri Jan 21 16:20:20 2022 +0100 chore: update frontend commit 8ecacfb Author: Fredrik Strand Oseberg <fredrik.no@gmail.com> Date: Fri Jan 21 12:02:05 2022 +0100 Fix/validate context (#1282) * fix: add context guards * fix: change error message * fix: remove console log commit 3735280 Merge: 9ce77e2 a5367ef Author: Thomas Heartman <thomas@getunleash.ai> Date: Fri Jan 21 10:55:23 2022 +0100 Merge pull request #1289 from Unleash/docs/proxy-client-keys docs: improve proxy commands commit 9ce77e2 Author: Thomas Heartman <thomas@getunleash.ai> Date: Fri Jan 21 10:20:51 2022 +0100 chore: Add rust sdk + sort SDKs list (#1288) commit a5367ef Author: Ivar Conradi Østhus <ivarconr@gmail.com> Date: Fri Jan 21 10:13:22 2022 +0100 docs: improve proxy commands commit b9d8c54 Merge: 61846b6 f8c40d1 Author: Youssef Khedher <khedher.youssef@hotmail.fr> Date: Fri Jan 21 09:05:21 2022 +0100 Merge pull request #1244 from Unleash/feat/update-toggle-type-description feat: update feature types description commit 61846b6 Author: Renovate Bot <bot@renovateapp.com> Date: Thu Jan 20 21:45:02 2022 +0000 chore(deps): update dependency typescript to v4.5.5 commit 9275fff Author: Renovate Bot <bot@renovateapp.com> Date: Thu Jan 20 19:21:10 2022 +0000 chore(deps): update dependency lint-staged to v12.2.2 commit 367b311 Author: Ivar Conradi Østhus <ivarconr@gmail.com> Date: Thu Jan 20 15:00:16 2022 +0100 fix: allow charset in content-type (#1241) commit d27542b Merge: ce555f5 3ce2ea0 Author: Thomas Heartman <thomas@getunleash.ai> Date: Thu Jan 20 12:44:37 2022 +0100 Merge pull request #1281 from Unleash/docs/add-cpr-vids docs: Add how-to videos to cpr how-tos commit ce555f5 Author: Philippe Vaillancourt <philippe.m.vaillancourt@gmail.com> Date: Thu Jan 20 12:26:00 2022 +0100 docs: Add ngx-unleash-proxy-client to community sdks (#1275) commit 23fda8d Merge: 3777791 1207d83 Author: sighphyre <liquidwicked64@gmail.com> Date: Thu Jan 20 09:25:17 2022 +0200 Merge pull request #1279 from Unleash/docs/rust-compatability chore: Add compatability table for Rust SDK commit 3777791 Author: Renovate Bot <bot@renovateapp.com> Date: Wed Jan 19 19:26:45 2022 +0000 chore(deps): update dependency @babel/core to v7.16.10 commit f8c40d1 Author: Youssef <khedher.youssef@hotmail.fr> Date: Wed Jan 19 19:54:49 2022 +0100 refactor: create migration to update feature types description commit 79c7d5a Author: Renovate Bot <bot@renovateapp.com> Date: Wed Jan 19 13:58:04 2022 +0000 chore(deps): update dependency lint-staged to v12.2.1 commit 1207d83 Author: sighphyre <liquidwicked64@gmail.com> Date: Wed Jan 19 16:49:18 2022 +0200 docs: Move proxy sdk compatibility to end of the compatability table commit 738d6eb Author: sighphyre <liquidwicked64@gmail.com> Date: Wed Jan 19 16:09:24 2022 +0200 Update website/docs/sdks/index.md Co-authored-by: Thomas Heartman <thomas@getunleash.ai> commit 3ce2ea0 Author: Thomas Heartman <thomas@getunleash.ai> Date: Wed Jan 19 15:08:25 2022 +0100 docs: simplify text commit c113081 Author: Thomas Heartman <thomas@getunleash.ai> Date: Wed Jan 19 15:05:28 2022 +0100 docs: Add how-to videos to cpr how-tos For simplicity I've added them as separate sections, but I'd love for them to be listed higher up. commit 76a5594 Author: sighphyre <liquidwicked64@gmail.com> Date: Wed Jan 19 15:58:57 2022 +0200 docs: Add in missing N/A for rust context provider compatibility commit 53034e8 Author: sighphyre <liquidwicked64@gmail.com> Date: Wed Jan 19 09:32:37 2022 +0200 chore: Add compatability table for Rust SDK commit 76713c9 Author: Renovate Bot <bot@renovateapp.com> Date: Tue Jan 18 22:36:07 2022 +0000 chore(deps): update dependency supertest to v6.2.2 commit 5ce4e2b Author: Renovate Bot <bot@renovateapp.com> Date: Tue Jan 18 15:10:06 2022 +0000 chore(deps): update dependency lint-staged to v12.2.0 commit 8868881 Merge: e30ff2b 4899eff Author: Thomas Heartman <thomas@getunleash.ai> Date: Tue Jan 18 12:40:44 2022 +0100 Merge pull request #1276 from Unleash/a11y/fix-contrast-on-hover-links-in-footer fix(docs/a11y): fix lack of contrast in on hovered links in footer commit e30ff2b Merge: 647a14c 184a18b Author: Thomas Heartman <thomas@getunleash.ai> Date: Tue Jan 18 12:27:31 2022 +0100 Merge pull request #1206 from Unleash/chore/update-workflows chore(workflows): update with new branch names commit 4899eff Author: Thomas Heartman <thomas.heartman+git@gmail.com> Date: Tue Jan 18 11:43:12 2022 +0100 fix(docs/a11y): fix lack of contrast in on hovered links in footer This commit changes the hover color of links in the footer to keep it accessible. The color will be the exact same as the un-hovered version. This is in line with the other links in the documentation. The links _do_ get underlined when hovered, so there is still a visual distinction between the states. I've added the variable in the `footer` section instead of in `:root` because the variable I assign it to (`--ifm-footer-link-color`) gets overridden closer to the footer, so if you set it in `:root`, you end up with the wrong value. addresses and closes https://github.com/Unleash/unleash.github.io/issues/8 commit 184a18b Merge: 14081c0 647a14c Author: Thomas Heartman <thomas@getunleash.ai> Date: Tue Jan 18 11:16:24 2022 +0100 Merge branch 'master' into chore/update-workflows commit 647a14c Merge: 380c182 a6f9c4f Author: Thomas Heartman <thomas@getunleash.ai> Date: Tue Jan 18 08:35:48 2022 +0100 Merge pull request #1273 from Unleash/a11y/fix-docs-link-contrast fix: use the Unleash purple for links / increase contrast commit 380c182 Author: Renovate Bot <bot@renovateapp.com> Date: Mon Jan 17 19:35:32 2022 +0000 chore(deps): update typescript-eslint monorepo to v5.10.0 commit a6f9c4f Author: Thomas Heartman <thomas.heartman+git@gmail.com> Date: Mon Jan 17 15:51:15 2022 +0100 fix: use the Unleash purple for links / increase contrast This increases the contrast from 3.42 to above 4.5, in compliance with the AA standard. commit 6867226 Merge: 3f3fbb3 cf35efe Author: Thomas Heartman <thomas@getunleash.ai> Date: Mon Jan 17 15:29:14 2022 +0100 Merge pull request #1268 from Unleash/docs/add-steps-for-running-proxy-via-node docs: add steps for running the proxy via Node commit cf35efe Author: Thomas Heartman <thomas@getunleash.ai> Date: Mon Jan 17 14:55:06 2022 +0100 Apply suggestions from code review Co-authored-by: sighphyre <liquidwicked64@gmail.com> commit 3f3fbb3 Author: Renovate Bot <bot@renovateapp.com> Date: Sun Jan 16 02:39:50 2022 +0000 chore(deps): update dependency eslint to v8.7.0 commit cab33f7 Author: Renovate Bot <bot@renovateapp.com> Date: Sat Jan 15 01:40:37 2022 +0000 chore(deps): update dependency ts-jest to v27.1.3 commit 611602c Author: Thomas Heartman <thomas.heartman+git@gmail.com> Date: Fri Jan 14 13:53:09 2022 +0100 docs: add steps for running the proxy via Node Also: restructure the steps relating to running it via docker to align better and to avoid repeating information. commit 0d6c440 Author: Youssef <khedher.youssef@hotmail.fr> Date: Fri Jan 7 11:25:10 2022 +0100 feat: update feature types description commit 14081c0 Author: Thomas Heartman <thomas.heartman+git@gmail.com> Date: Thu Dec 23 14:12:19 2021 +0100 chore(workflows): update with new branch names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the hover color of links in the footer to keep it
accessible.
The color will be the exact same as the un-hovered version. This is in
line with the other links in the documentation. The links do get
underlined when hovered, so there is still a visual distinction
between the states.
I've added the variable in the
footersection instead of in:rootbecause the variable I assign it to (
--ifm-footer-link-color) getsoverridden closer to the footer, so if you set it in
:root, you endup with the wrong value.
addresses and closes https://github.com/Unleash/unleash.github.io/issues/8