Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/impression data #1310

Merged
merged 7 commits into from
Feb 3, 2022
Merged

Feat/impression data #1310

merged 7 commits into from
Feb 3, 2022

Conversation

FredrikOseberg
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jan 28, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/unleash-team/unleash-docs/H1Mduf88Z1sS8BppiXXaeom4hsW5
✅ Preview: https://unleash-docs-git-feat-impression-data-unleash-team.vercel.app

@github-actions
Copy link

github-actions bot commented Jan 28, 2022 •
edited

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟢 Statements 91.39% 4734/5180
🟢 Branches 80.27% 724/902
🟢 Functions 86.63% 1108/1279
🟢 Lines 92.81% 5421/5841

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 435027e

ivarconr
ivarconr reviewed Jan 28, 2022
View reviewed changes
Copy link
Member

@ivarconr ivarconr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Would like to see a small e2e test for this value as well.

chriswk
chriswk approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@FredrikOseberg
Copy link
Contributor Author

Nice work. Would like to see a small e2e test for this value as well.

Thanks! You mean other than the ones added to features.e2e?

@FredrikOseberg FredrikOseberg merged commit 6520aa1 into main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarconr ivarconr ivarconr left review comments

@chriswk chriswk chriswk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FredrikOseberg @ivarconr @chriswk