docs: add docs for impression data

[FredrikOseberg]

• Add documentation that details the new impression data feature

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/unleash-team/unleash-docs/4vEGoWA3qu3mJ4XrVRvdVzrEXm8u
✅ Preview: https://unleash-docs-git-docs-impression-data-unleash-team.vercel.app

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟢	Statements	91.39%	4734/5180
🟢	Branches	80.27%	724/902
🟢	Functions	86.63%	1108/1279
🟢	Lines	91.31%	4636/5077

Test suite run success

789 tests passing in 116 suites.

Report generated by 🧪jest coverage report action from 8ef9fed

[thomasheartman]

Great work 🙌🏼 I think this is a really good starting point and that it covers a lot of the most important parts of the feature. I think it could benefit from some work on the structure, though.

Personally, I'd like to see a clearer description of what impression data is, what form it takes (e.g. what data does it carry), and how you use it.

Outlined the way it is now, it's more like a how-to guide (which is great, but not the same as reference documentation as defined by diataxis). I can see a single paragraph on "how to enable it" being useful though.

That said, I'm very happy to discuss this, and I also wouldn't mind taking a stab at reorganizing it a bit if you'd want?

Edit

Oh, and I chucked in a couple minor suggestions that jumped out at me regarding syntax highlighting, documentation ordering, and a sentence potentially missing a word 🤓

[FredrikOseberg]

Great work 🙌🏼 I think this is a really good starting point and that it covers a lot of the most important parts of the feature. I think it could benefit from some work on the structure, though.

Personally, I'd like to see a clearer description of what impression data is, what form it takes (e.g. what data does it carry), and how you use it.

Outlined the way it is now, it's more like a how-to guide (which is great, but not the same as reference documentation as defined by diataxis). I can see a single paragraph on "how to enable it" being useful though.

That said, I'm very happy to discuss this, and I also wouldn't mind taking a stab at reorganizing it a bit if you'd want?

Edit

Oh, and I chucked in a couple minor suggestions that jumped out at me regarding syntax highlighting, documentation ordering, and a sentence potentially missing a word 🤓

Thanks for the feedback! If you want to take a stab at reorganizing it that would fantastic.

[thomasheartman]

Looks good to me! 🚂 Thanks for putting this together 🙌🏼