docs(a11y): fix a number of contrast issues with the dark theme #1334
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/unleash-team/unleash-docs/7arwSptY4sDrcR2Mk8tVahTRWUdL |
Coverage report
Test suite run success789 tests passing in 116 suites.Report generated by 🧪jest coverage report action from fe69c1d |
| @@ -25,11 +25,6 @@ module.exports = { | |||
| src: 'img/logo.svg', | |||
| }, | |||
| items: [ | |||
| { | |||
There was a problem hiding this comment.
Good question! I removed this one because that link doesn't go anywhere new. Now that all docs are on the same page, it doesn't really serve a purpose anymore. The link right next to it ("Unleash") takes you to the same place.
Furthermore, because of the highlighting regex it would sometimes be link-colored, and sometimes not, which is both inconsistent and confusing.
However, I'd be happy to leave it in if you think it still serves a purpose?
There was a problem hiding this comment.
@ivarconr Thoughts on this? If you'd prefer to leave it in, I'm fine with that, but it'll take a little more styling caution (or maybe just removing the regex?) and it may be more trouble than it's potentially worth.
There was a problem hiding this comment.
tbh I was a bit fast and though this was a redirect rule. All fine!
New contrast is 7.99 (AAA).
This commit introduces a new primary color gradient palette to replace the dark / mossy green that we use in the light theme. It's got a very small range, so we should probably expand on it in the future, but for now it'll do a _lot_ better than it did previously.
thomasheartman
force-pushed
the
docs/a11y-dark-theme-fixes
branch
from
aa4d7c3
to
fe69c1d
Compare
It seems that some changes (some recent, some older) have introduced a number of contrast issues to the doc dark theme. This PR fixes issues with:
Most changes should be pretty uncontroversial, but it might be worth discussing the new
--ifm-color-primarygradient at some point.Optionally: we should develop a dark mode palette for Unleash and use that.