Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook events for feature tag and untag #1355

Merged
merged 2 commits into from Apr 6, 2022
Merged

Conversation

abhinav1708
Copy link
Contributor

Addition of feature tag and untag events in webhook
This will user in integration if they want to perform some action based on tag events

@vercel
Copy link

vercel bot commented Feb 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/unleash-team/unleash-docs/B4U5t7625e4oefSgwVpcW1ePKgQ6
✅ Preview: https://unleash-docs-git-fork-abhinav1708-main-unleash-team.vercel.app

@abhinav1708
Copy link
Contributor Author

@ivarconr Test Coverage and build step failed, I checked the details and found all tests was successful and build failed because of some HTTP error (maybe due to coverage report not found)
Seems like a build issue, please let me know if something needs to be done in my pull request to fix this.

@abhinav1708 abhinav1708 marked this pull request as draft February 14, 2022 10:59
@abhinav1708 abhinav1708 reopened this Feb 14, 2022
@abhinav1708 abhinav1708 marked this pull request as ready for review February 14, 2022 11:01
@abhinav1708
Copy link
Contributor Author

@chriswk @ivarconr I might have found the reason for build step failure, As I don't have written permission on this repo, the build job is being executed with reading permission so it fails to write a coverage report and generates Error: HTTP error: Resource not accessible by integration.
I checked all tests have passed but due to permission it didn't write file, I have crosschecked permission in the GitHub token in the setup build step
I don't know this can be resolved, as for passing the job I should have write permission
Screenshot_20220218-014417

@ivarconr ivarconr merged commit 66c66c7 into Unleash:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants